[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: >Dave, Toolbox



In article <jmk3.720814985@crux1.cit.cornell.edu> jmk3@crux3.cit.cornell.edu (Jay M. Krell) writes:
>>killPort and newPort
> The source to these is available, and I have it. But there are no
>proper docs for what newPort takes and the newPort source (I don't know about
>the object) looks like it has bugs. Specifically, I think it sets up
>the stack wrong before 2 calls to RectRgn. [...]

There were some paper docs, but no full electronic docs.

You're correct about the bad parameters to a RectRgn call.  My corrected
version that didn't wind up in 6.0 looked like this:

@portOpened
        pha     ;Push parms to make visRgn rectangular.
        pha
        _GetVisHandle
        pea 0
        tdc
        clc
        adc #ourPortRect
        pha
        _RectRgn

*** Note: This was buggy in the DTS version.  Was calling RectRgn with
***       garbage once.

        pha     ;Push parms to make clipRgn rectangular.
        pha
        _GetClipHandle
        pea 0
        tdc
        clc
        adc #ourPortRect
        pha
        _RectRgn

        pea 0   ;Get the new port's locInfo structure.
        tdc
        clc
        adc #portInfo
        pha
        _GetPortLoc
        ...

-- 
David A. Lyons, Apple Computer, Inc.      |   DAL Systems
Apple II System Software Engineer         |   P.O. Box 875
Internet:dlyons@apple.com                 |   Cupertino, CA 95015-0875

My opinions are my own, not Apple's.