Re: Bug(?) in 6.0.1 Pascal FST

[nathan@visi.com (Nathan Mates)]

In article <webmaster-0208961503500001@pm3-081.sct.fr>,
Michael Guitton <webmaster@cardshow.com> wrote:
>Could you describe the whole patch of the FST code in
>comp.sys.apple2.programmer?

   It's a total of changing _one_ byte in the fst. My notes for
offsets into the FST are at home, but in the disk checking routine
(basically, the OS gives the FST a disk and says "Is this one of
yours"), after reading in the block where the volume name was, it
looks over the volume name field for "legal" characters. In a loop, it
went over the characters, and initially checked to see if the value
was < $30 ('0'). If so, it considered it a bad disk. I changed the
check to <$21 ('!'). 

   If you were looking for a disassembly of the FST, I don't have
one. I dropped a breakpoint on entry, and just followed the code in
GSBug until I figured out what the heck it was doing. 

>Would it be possible to patch the FST directly (like it was done for the
>HFS FST)?

   1) As I didn't know all of the disk naming rules offhand at the
time, I chose $21 fairly arbitrarily. Now that I have some real hard
facts as to what it should be, I can release an update to GUPP, and
it'll be transparent to everyone. With a memory patch, all you have to
do is shiftboot or disable GUPP, and any to all effects are gone.
Patching the binaries is far more risky, involves making backups, and
the like. No thanks.

   Almost nobody uses the Pascal FST (or this would have been known
and complained about a _long_ time ago), and if they do, they might as
well have GUPP installed, as GUPP fixes Finder 6.0.1, GNO/ME Kernel,
and other 6.0.1 bugs

>There is the same kind of problem with the High Sierra FST as well. A
>patch by Jawaid Bazyar was available through GS+.

   Well, I don't have a CD-Rom on my GS (hope to fix that one of these
months), so I can't really investigate it. (And _DON'T_ send me the
details on the GS+ patch. That's copyrighted by them, and they deserve
to get their $'s worth by having people buy their software.)

Nathan Mates

--
<*> Nathan Mates http://www.visi.com/~nathan/      <*>
# What are the facts? Again and again and again-- what are the _facts_?
# Shun wishful thinking, avoid opinion, care not what the neighbors
# think-- what are the facts, and to how many decimal places?  -R.A. Heinlein